Skip to content

fix(auth): bind detached downloads to account - #432

Merged
veryCrunchy merged 1 commit into
fix/authenticated-request-target-policyfrom
fix/authenticated-request-chunk-upload
Sep 4, 2026
Merged

fix(auth): bind detached downloads to account#432
veryCrunchy merged 1 commit into
fix/authenticated-request-target-policyfrom
fix/authenticated-request-chunk-upload

Conversation

@veryCrunchy

@veryCrunchy veryCrunchy commented Sep 1, 2026

Copy link
Copy Markdown
Member

What changed

  • validate Android and desktop detached-download targets against the signed-in account origin and base path before attaching credentials
  • follow only bounded account-safe GET redirects through the authenticated request policy from PR fix(auth): bind login and DAV requests to account #428
  • keep coroutine cancellation bound to the active request across redirect hops
  • retain custom request headers, byte limits, ETag validation, and network diagnostics on the final response

Validation

Passed on the dedicated Linux build host with the same production and test blobs now in this branch:

  • :ui:desktopTest --tests dev.obiente.nextcloudnative.app.DesktopDetachedDownloadTest
  • :androidApp:testDebugUnitTest --tests dev.obiente.nextcloudnative.AndroidDetachedDownloadTransportTest
  • :androidApp:assembleDebug

Passed again on the exact rewritten branch:

  • bash tools/check-kotlin-architecture.sh
  • bash tools/check-repository.sh
  • git diff --check

Compatibility and risk

  • Android and desktop detached file, attachment, and historical-version downloads only
  • depends on PR fix(auth): bind login and DAV requests to account #428 and is one commit above its exact head
  • tests use synthetic MockWebServer origins; no live server was used
  • broader authenticated service calls and media playback transports remain outside this slice

Visual changes

Not applicable.

Advances #106

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 19:19 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · 4a38f5a8ec3b · Removed

View preview status

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T00:07:10.315739Z 4a38f5a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 19:20 Destroyed
@veryCrunchy veryCrunchy changed the title fix/authenticated request chunk upload fix(sync): secure desktop chunk upload transport Sep 1, 2026
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 3f0c6af to 075999f Compare September 1, 2026 19:29
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 19:29 Destroyed
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 075999f to 531ac99 Compare September 1, 2026 19:51
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 19:52 Destroyed
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 531ac99 to 7c90a6a Compare September 1, 2026 20:18
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 20:19 Destroyed
@veryCrunchy veryCrunchy changed the title fix(sync): secure desktop chunk upload transport fix(auth): bind detached downloads to account Sep 1, 2026
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 7c90a6a to 7549279 Compare September 1, 2026 20:48
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 20:48 Destroyed
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 7549279 to 7cfa432 Compare September 1, 2026 21:10
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 1, 2026 21:10 Destroyed
@veryCrunchy
veryCrunchy force-pushed the fix/authenticated-request-chunk-upload branch from 7cfa432 to 4a38f5a Compare September 4, 2026 00:03
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #432 / NC Native September 4, 2026 00:03 Destroyed
@veryCrunchy
veryCrunchy merged commit 567285f into main Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant